Fix QT timer call that was broken by formatting PR #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flova
requested review from
JanNiklasFeld,
ayin21,
jaagut,
jgueldenstein and
texhnolyze
|
Contrary to the black documentation this does not work: def timerEvent(self, timer_event): # fmt: skip # noqa: N802one instead needs to use the multiline variant.... Maybe the black version is too old |
jaagut
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR #96 made all camel case to snake case. Sadly this camel case was an override of a parent function. This resulted in the rqt viz not updating automatically unless somethings was clicked.
Also removes some unused files