Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bench): update import statement and module handling in run.js #2471

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

chansuke
Copy link
Contributor

@chansuke chansuke commented Apr 15, 2024

Summary

This PR follows up on #34 :)

Refactored run.js to utilize import statements, improving module handling and more.

Test Plan

Checked run.js with biome and checked bench with:

$ docker build --rm -f Dockerfile.benchmark . --progress plain

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 40e5167
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/661d3e266199730009acd85f
😎 Deploy Preview https://deploy-preview-2471--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ematipico ematipico merged commit 33e7fa8 into biomejs:main Apr 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants