Fix itertools dependency #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes itertools dependency. Allow version 0.12. This deduplicates dependencies
Open
readysetbot
pushed a commit
to readysettech/readyset
that referenced
this pull request
May 24, 2024
Update mysql_common to 0.32.3 in order to get the new collation data dictionary support. As part of this update, we also need to downgrade the version of sqlformatter and prometheus-parse as they use itertools v0.12.1 which is currently incompatible with criterion.rs and cause cargo check to fail. We should be able to updated them once again when a release with [1] is published. [1]: bheisler/criterion.rs#743 Ref: REA-4382 Closes: #1258 Change-Id: I36614184b749c96c0046c88ca5e1c6a2d186eff6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes itertools dependency (
0.12instead of12).Include version 0.12, to deduplicate dependencies