-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reexport std::hint::black_box #701
base: master
Are you sure you want to change the base?
Conversation
Would it make sense to possibly have a |
That's also a good option. @bheisler any opinions? |
I think that sounds like a good idea. |
Oh, wow. They finally stabilized Yeah, deprecating our hacky replacement for |
Stable (const unstable) since 1.66 ... so that's 5 versions now if I count correctly. :) |
I've added a deprecated wrapper for |
You will probably need to bump the MSRV in CI and elsewhere since it is currently stating and testing 1.64 |
Alternatively, deprecate in favor of std::hint but keep the old implementation for those that don’t want to update? Up to the maintainers! |
Any chance the |
I've bumped the MSRV and removed the use of the |
I would really love to see this merged and a new release published. asan keeps sporadically triggering a false positive on the current |
@bheisler Is there anything blocking this? |
Fixes #700.