Fix bug where time over the maximum would be reported as 1ms in quick mode #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sigh, might need to bump MSRV to 1.60 |
|
Also just ran into this bug. Will this be released soon? |
|
@Victor-N-Suadicani: The fix is included in the new version 0.5.0, however it will still crash in quick mode in those cases without the "--noplot" parameter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #658.
See also the minimal working example at https://github.com/KonradHoeffner/criterion-quick-bug.
This will report the correct time of the first and only iteration in quick mode.
Note that it will still crash with plotting due to the values being the same, so
cargo bench -- --quick --noplotmust be used.