Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure job context does not leak into extensions whenperform_now is called within another job #1336

Merged
merged 1 commit into from Apr 24, 2024
Merged

Ensure job context does not leak into extensions whenperform_now is called within another job #1336

merged 1 commit into from Apr 24, 2024

Conversation

bensheldon
Copy link
Owner

@bensheldon bensheldon commented Apr 23, 2024 •
edited

@bensheldon bensheldon mentioned this pull request Apr 23, 2024
Closed
@bensheldon bensheldon force-pushed the concurrency-wrap branch 2 times, most recently from 46c7d57 to 4a63683 Compare April 23, 2024 21:59
@bensheldon bensheldon added the bug Something isn't working label Apr 23, 2024
@bensheldon bensheldon changed the title Ensure concurrency controls are ignored when perform_now inside another job Ensure job context does not leak into extensions whenperform_now is called within another job Apr 23, 2024
@bensheldon bensheldon merged commit 59b8c68 into main Apr 24, 2024
21 checks passed
@bensheldon bensheldon deleted the concurrency-wrap branch April 24, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
GoodJob Backlog v2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Executing perform_now on a good_job with GoodJobs::ActiveJobExtensions::Concurrency can run twice
1 participant
@bensheldon