my implementation of a file acl module #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is neither intended to exist alongside the current acl module, nor to replace it, but to provide input which (I hope) can contribute the current acl module's development
|
hi, I appreciate the feedback and contribution. #1) I avoided doing multiple entries in a single invocation as it complicated the code a lot, I left it up to the user and with_items: #2) The updated module does something very close to this, it just always uses the long form of an entry. #3) Not really, relies mostly on FreeBSD implementation (which is what I was using at the time), since the command is not in Posix standards it might vary (I've tested on Gentoo, Ubuntu and Debian also). The -h was a typo, I need to remove it. It was a placeholder for when I was still contemplating the recursive function. #4) yep, this one is not as easy as one would think, the last version does a much better job now. I doubt I'll be changing as --test is not available on all setfacl binaries I have used. #5) this is what the posix1e module already does, but I was asked not to use it to reduce dependencies and in the end it is simpler code. #6) I do string matching on the first character, the result is the same. #7) we already have that with the using the ansible convention state=absent #8) that is what production is for! kidding aside, I have a few minor tests I haven't pushed to the main repo yet, they aren't perfect but it is a start. Just to point out, I'm not an ansible maintainer, just the module author, discussion or ideas on how to enhance ansible might be better on the ansible-devel mailing list (google group). At least there you'll get more opinions than just mine (also that is where the guys with commit privileges to ansible proper will be). |
|
Thanks for your quick reply, I'm looking forward to the acl-module in Ansible 1.5 |
|
We might be able to implement a 'clear all and insert this' with: -b Remove all ACL entries except for the three required entries just might be a bit complicated with 'changed' status |
|
closing this as I moved the conversation to ansible-devel |
bcoca
pushed a commit
that referenced
this pull request
Mar 2, 2014
added octal representation of mode and made md5 checksumming optional
bcoca
added a commit
that referenced
this pull request
Aug 18, 2015
… own modules falls back to current service module and requries service mgr facts and new service modules
bcoca
pushed a commit
that referenced
this pull request
Sep 26, 2015
More tests, better handling of list arguments to _split_pattern
bcoca
pushed a commit
that referenced
this pull request
Oct 3, 2015
Now we have the following ways to set additional arguments:
1. [ssh_connection]ssh_args in ansible.cfg: global setting, prepended to
every command line for ssh/scp/sftp. Overrides default ControlPersist
settings.
2. ansible_ssh_common_args inventory variable. Appended to every command
line for ssh/scp/sftp. Used in addition to ssh_args, if set above, or
the default settings.
3. ansible_{sftp,scp,ssh}_extra_args inventory variables. Appended to
every command line for the relevant binary only. Used in addition to
#1 and #2, if set above, or the default settings.
3. Using the --ssh-common-args or --{sftp,scp,ssh}-extra-args command
line options (which are overriden by #2 and #3 above).
This preserves backwards compatibility (for ssh_args in ansible.cfg),
but also permits global settings (e.g. ProxyCommand via _common_args) or
ssh-specific options (e.g. -R via ssh_extra_args).
Fixes ansible#12576
bcoca
pushed a commit
that referenced
this pull request
Mar 9, 2016
This implements solution #1 in the proposal ansible#14860. It only shows the diff if the task induced a change, which means that if the changed_when control overrides the task, not diff will be produced. See ansible#14860 for a rationale and the use-case.
bcoca
pushed a commit
that referenced
this pull request
Oct 13, 2016
bcoca
pushed a commit
that referenced
this pull request
Feb 17, 2017
* Add a vault 'encrypt_string' command.
The command will encrypt the string on the command
line and print out the yaml block that can be included
in a playbook.
To be prompted for a string to encrypt:
ansible-vault encrypt_string --prompt
To specify a string on the command line:
ansible-vault encrypt_string "some string to encrypt"
To read a string from stdin to encrypt:
echo "the plaintext to encrypt" | ansible-vault encrypt_string
If a --name or --stdin-name is provided, the output will include that name in yaml key value format:
$ ansible-vault encrypt_string "42" --name "the_answer"
the_answer: !vault-encrypted |
$ANSIBLE_VAULT;1.1;AES256
<vault cipher text here>
plaintext provided via prompt, cli, and/or stdin can be mixed:
$ ansible-vault encrypt_string "42" --name "the_answer" --prompt
Vault password:
Variable name (enter for no name): some_variable
String to encrypt: microfiber
# The encrypted version of variable ("some_variable", the string #1 from the interactive prompt).
some_variable: !vault-encrypted |
$ANSIBLE_VAULT;1.1;AES256
< vault cipher text here>
# The encrypted version of variable ("the_answer", the string #2 from the command line args).
the_answer: !vault-encrypted |
$ANSIBLE_VAULT;1.1;AES256
< vault cipher text here>
Encryption successful
* add stdin and prompting to vault 'encrypt_string'
* add a --name to encrypt_string to optional specify a var name
* prompt for a var name to use with --prompt
* add a --stdin-name for the var name for value read from stdin
bcoca
pushed a commit
that referenced
this pull request
Oct 24, 2018
* Add Support of healthcheck in docker_container module Fixes ansible#33622 Now container can be started with healthcheck enabled Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com> * Extend docker_container healthcheck (#1) * Allowing to disable healthcheck. * Added test for healthcheck. * Make sure correct types are used. * Healthcheck needs to be explicitly disabled with test: ['NONE']. * pep8 fixes Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com> * Fix bug if healthcheck interval is 1 day or more `timedelta` object has days too and seconds are up to one day. Therefore use `total_seconds()` to convert time into seconds. Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com> * Add test for healthcheck when healthcheck is not specified This is to avoid the situation when healthcheck is not specified and treat this as healthcheck is changed or removed. Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com> * Convert string syntax for healthcheck test to CMD-SHELL Also add another test case to check idempotency when healthcheck test is specified as string Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com> * Playbook fails if minimun docker version is not satisfy for healthcheck This is to make more consistent with other non-supported options. Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
bcoca
pushed a commit
that referenced
this pull request
Feb 18, 2019
* postgresql_ext: cascade extension creating/deleting (#1) * postgresql_ext: cascade extension creating/deleting * Address code review feedback
bcoca
pushed a commit
that referenced
this pull request
Feb 18, 2019
* Enable 'changed' var with ufw check mode * Fix from comment of the PR + Unit Test * Fix on ufw module after the second review - delete rules change works in check mode - simplify execute def & use it on every call process - improved regexp - rename vars defaults to current_default_values * Add ignore error to execute() and use it in get_current_rules() * Update after third code review (introduce change in changed status) * Adjust tests and fix some problems (#1) * 'active' also appears in 'inactive'. * 'reject' is also a valid option here. * For example for reloaded, changed will be set back to False here. * Improve and adjust tests. * Fix after merging integration test * handle "disabled" on default routed * Add /var/lib/ufw/.. rules files * add unit test * Fix pep8 formatting error * Separate ipv6 and ipv4 rules process from checkmode * fix non-ascii error on ci * Some change after review * Add unit test with sub network mask * rename is_match function by is_starting * add changelog fragment
bcoca
pushed a commit
that referenced
this pull request
Mar 8, 2019
…nsible#49191) (ansible#53445) * Fix for "AttributeError: 'module' object has no attribute 'cursors'" (ansible#49191) (#1) * Fix for "AttributeError: 'module' object has no attribute 'cursors'" (ansible#49191) * Adding changelog fragment for issue ansible#49191 and the following PR. * Update lib/ansible/module_utils/mysql.py Co-Authored-By: timorunge <timorunge@users.noreply.github.com>
bcoca
pushed a commit
that referenced
this pull request
Apr 2, 2019
* Add win_hosts module added win_hosts module for easier manipulation of hosts entries in "%windir%\system32\drivers\etc\hosts" for windows systems * Update win_hosts.py * Add alias support to win_hosts module (#1) * win_hosts supports aliases added support for adding / removing aliases from a host entry, rather than adding a new entry added ability for win_hosts to detect aliases: `192.168.1.1 alias1 alias2 alias3` ``` win_hosts: host_name: alias2 ip_address: 192.168.1.1 ``` will result in `192.168.1.1 alias1 alias3` also includes `replace` and `add` as options for `ip_action` (`replace` is default) for example: ``` 192.168.1.1 my_reused_alias 192.168.1.2 my_reused_alias ``` with ``` win_hosts: host_name: my_reused_alias ip_address: 192.168.1.3 ip_action: add ``` the result will be ``` 192.168.1.1 my_reused_alias 192.168.1.2 my_reused_alias ``` but with `ip_action=replace` the result would be ``` 192.168.1.3 my_reused_alias ``` * fixed metadata version and version added * fix line endings * upload fixed line endings try to upload the file with the fixed line endings * aliases and canonical names are separate entities. added IPv4 and IPv6 validation * only makes changes if "check_mode" is false * improved behavior for duplicate aliases/entries. * adding tests * missing aliases file * fix trailing whitespace and uses explicit paths * Tweak tests to copy and restore original hosts file
bcoca
pushed a commit
that referenced
this pull request
Apr 11, 2019
…nsible#49191) (ansible#53445) * Fix for "AttributeError: 'module' object has no attribute 'cursors'" (ansible#49191) (#1) * Fix for "AttributeError: 'module' object has no attribute 'cursors'" (ansible#49191) * Adding changelog fragment for issue ansible#49191 and the following PR. * Update lib/ansible/module_utils/mysql.py Co-Authored-By: timorunge <timorunge@users.noreply.github.com> (cherry picked from commit b45b599)
bcoca
pushed a commit
that referenced
this pull request
Jan 13, 2020
ansible#65228) * adding encoding dump/import support for the mysql_db module, with updated documentation, and full test suite * fixing lint issue test #3 * fixing lint issue test #1 * fixing lint issue test #1 second time * Improving Test to be re-entrant * improving test to not fail on centos/6 * Update test/integration/targets/mysql_db/tasks/encoding_dump_import.yml Comminting suggestion Co-Authored-By: Benjamin MALYNOVYTCH <bmalynovytch@users.noreply.github.com> * Update test/integration/targets/mysql_db/tasks/encoding_dump_import.yml comminting suggestion Co-Authored-By: Benjamin MALYNOVYTCH <bmalynovytch@users.noreply.github.com> * adding comment Adding comment to explain test strategy * Update test/integration/targets/mysql_db/tasks/encoding_dump_import.yml Co-Authored-By: Benjamin MALYNOVYTCH <bmalynovytch@users.noreply.github.com> * Update test/integration/targets/mysql_db/tasks/encoding_dump_import.yml Co-Authored-By: Benjamin MALYNOVYTCH <bmalynovytch@users.noreply.github.com> * Update test/integration/targets/mysql_db/tasks/encoding_dump_import.yml accepted Co-Authored-By: Andrey Klychkov <aaklychkov@mail.ru> * Update test/integration/targets/mysql_db/tasks/encoding_dump_import.yml Co-Authored-By: Andrey Klychkov <aaklychkov@mail.ru> * Update encoding_dump_import.yml * Fixing typoo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
a while ago, I intended to propose a few changes to Ansible's ACL-module. I based these on the version in release 1.4.4 since I had troubles using the devel-branch at the time.
Since then, Ansible's acl-module has changed quite a bit, and my changes are not compatible any more. However, maybe my version of the module can still provide a little input - this is why I send this request. (this is neither intended to exist alongside the current acl module, nor to replace it)
PS: Unfortunately, I wrongly sent an unfinished version of this pull request to ansible/ansible instead of bcoca/ansible about an hour ago. This was not intended, and I apologize for any confusion.
A few comments regarding the module
I hope that one or the other fragment of my acl-implementation can be useful in the further development of Ansible's ACL module
regards,
Bernhard