Fixed warnings in various targets #3345
Merged
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
commented
Mar 15, 2025
| @@ -4,7 +4,6 @@ authors = { workspace = true } | |||
| description = { workspace = true } | |||
| homepage = { workspace = true } | |||
| license = { workspace = true } | |||
| license-file = { workspace = true } | |||
There was a problem hiding this comment.
This addresses
INFO: From Executing genrule //cargo/cargo_toml_variable_extractor/testdata:gen_workspace_subcrate_cargo_output:
warning: /private/var/folders/h4/_xm41cq11v90znmm9dz87wdc0000gn/T/determinism-Wp88Oa/repo_a_output/597f7fd25c22d39899b3eeb4bb3cf7ea/sandbox/darwin-sandbox/122/execroot/_main/cargo/cargo_toml_variable_extractor/testdata/workspace/subcrate/Cargo.toml: no edition set: defaulting to the 2015 edition while 2021 is compatible with `rust-version`
warning: /private/var/folders/h4/_xm41cq11v90znmm9dz87wdc0000gn/T/determinism-Wp88Oa/repo_a_output/597f7fd25c22d39899b3eeb4bb3cf7ea/sandbox/darwin-sandbox/122/execroot/_main/cargo/cargo_toml_variable_extractor/testdata/workspace/subcrate/Cargo.toml: only one of `license` or `license-file` is necessary
`license` should be used if the package license can be expressed with a standard SPDX expression.
`license-file` should be used if the package uses a non-standard license.
See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information.
Compiling subcrate v0.2.0 (/private/var/folders/h4/_xm41cq11v90znmm9dz87wdc0000gn/T/determinism-Wp88Oa/repo_a_output/597f7fd25c22d39899b3eeb4bb3cf7ea/sandbox/darwin-sandbox/122/execroot/_main/cargo/cargo_toml_variable_extractor/testdata/workspace/subcrate)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.08s
Running `cargo/cargo_toml_variable_extractor/testdata/workspace/target/debug/subcrate`
UebelAndre
commented
Mar 15, 2025
| @@ -28,7 +28,7 @@ pub struct CrateDependency { | |||
| pub alias: Option<String>, | |||
|
|
|||
| /// Local path of this dependency if provided. This captures local paths from both the | |||
| /// [dependencies] table and the [patches] table so they can be used in rendering. | |||
| /// `[dependencies]` table and the `[patches]` table so they can be used in rendering. | |||
There was a problem hiding this comment.
This addresses
INFO: From Generating Rustdoc for @@//crate_universe:cargo_bazel:
warning: unresolved link to `dependencies`
--> crate_universe/src/context/crate_context.rs:31:10
|
31 | /// [dependencies] table and the [patches] table so they can be used in rendering.
| ^^^^^^^^^^^^ no item named `dependencies` in scope
|
= help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
= note: `#[warn(rustdoc::broken_intra_doc_links)]` on by default
warning: unresolved link to `patches`
--> crate_universe/src/context/crate_context.rs:31:39
|
31 | /// [dependencies] table and the [patches] table so they can be used in rendering.
| ^^^^^^^ no item named `patches` in scope
|
= help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
warning: 2 warnings emitted
UebelAndre
commented
Mar 15, 2025
| @@ -82,7 +82,7 @@ genrule( | |||
| exclude = ["workspace/target/**"], | |||
| ), | |||
| outs = ["workspace_subcrate_cargo_output"], | |||
| cmd = "RUSTC=$(location //tools/upstream_wrapper:rustc) $(location //tools/upstream_wrapper:cargo) run --manifest-path=cargo/cargo_toml_variable_extractor/testdata/workspace/subcrate/Cargo.toml > $@", | |||
| cmd = "RUSTC=$(location //tools/upstream_wrapper:rustc) $(location //tools/upstream_wrapper:cargo) run --quiet --manifest-path=cargo/cargo_toml_variable_extractor/testdata/workspace/subcrate/Cargo.toml > $@", | |||
There was a problem hiding this comment.
This fixes
INFO: From Executing genrule //cargo/cargo_toml_variable_extractor/testdata:gen_workspace_subcrate_cargo_output:
warning: /private/var/tmp/_bazel_user/76282c66b0dfe3c5cb9a230bdc913a52/sandbox/darwin-sandbox/566/execroot/_main/cargo/cargo_toml_variable_extractor/testdata/workspace/subcrate/Cargo.toml: no edition set: defaulting to the 2015 edition while 2021 is compatible with `rust-version`
Compiling subcrate v0.2.0 (/private/var/tmp/_bazel_user/76282c66b0dfe3c5cb9a230bdc913a52/sandbox/darwin-sandbox/566/execroot/_main/cargo/cargo_toml_variable_extractor/testdata/workspace/subcrate)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.36s
Running `cargo/cargo_toml_variable_extractor/testdata/workspace/target/debug/subcrate`
illicitonion
approved these changes
Mar 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.