Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add NIX_LDs vars to work on NixOS #3304

Merged
merged 1 commit into from
Feb 27, 2025
Merged

fix: add NIX_LDs vars to work on NixOS #3304

merged 1 commit into from
Feb 27, 2025
+2 −0

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Feb 27, 2025 •
edited
Loading

Re-implements #3223 (special thanks to @tkr-sh!)

No bazel command will work on NixOS when using crate_universe because NIX_LD is removed by .env_clear().
See https://github.com/nix-community/nix-ld
This fix is fairly simple, and makes the command work on NixOS.

closes #3224

@UebelAndre
fix: add NIX_LDs vars to work on NixOS

Verified

This commit was signed with the committer’s verified signature.
luke-hill Luke Hill
GPG key ID: 7BBDB431C127E58C
Verified
Learn about vigilant mode
Loading
Loading status checks…
296f8f5
@UebelAndre UebelAndre marked this pull request as ready for review February 27, 2025 20:34
@UebelAndre UebelAndre enabled auto-merge February 27, 2025 20:34
@UebelAndre UebelAndre added this pull request to the merge queue Feb 27, 2025
illicitonion
illicitonion approved these changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@UebelAndre UebelAndre mentioned this pull request Feb 27, 2025
Closed
Merged via the queue into bazelbuild:main with commit 42d8d90 Feb 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: add NIX_LDs vars to work on NixOS
2 participants
@UebelAndre @illicitonion