Add support for ppc64le architecture #3259
Conversation
| @@ -117,7 +117,7 @@ def get_host_triple(repository_ctx, abi = None): | |||
| # Detect the host's cpu architecture | |||
|
|
|||
| supported_architectures = { | |||
| "linux": ["aarch64", "x86_64", "s390x"], | |||
| "linux": ["aarch64", "x86_64", "s390x", "powerpc64le"], | |||
There was a problem hiding this comment.
Is the host platform ever gonna be powerpc? I think the only changes you need are what was done in rust/platform/triple_mappings.bzl.
There was a problem hiding this comment.
If I understand correctly, the host platform is the platform the bazel binary is executed on. When attempting to utilize rules_rust and executing bazel on a ppc64le host, I did receive the failure message from _validate_cpu_architecture, causing the build to fail. Marking it as supported here seems necessary to avoid failure in that case.
Jenkins-J
force-pushed
the
ppc64le-support
branch
from
33e9753 to
7390d92
Compare
|
@Jenkins-J Looks like this PR will need to be rebased and the crate_universe examples repinned. |
|
@UebelAndre I was able to rebase the PR. What is the recommended way to repin the crate_universe examples? I am not familiar with that process. Is there a specific bazel rule in the cargo_universe directory that I must run with |
@Jenkins-J you should be able to run this script and commit the results: //util/repin_all.sh |
Allow rules_rust module to be used on the ppc64le architecture. Signed-off-by: James Jenkins <James.Jenkins@ibm.com>
Jenkins-J
force-pushed
the
ppc64le-support
branch
from
7390d92 to
1b28c5f
Compare
Allow rules_rust module to be used on the ppc64le architecture.