Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated Android example to bzlmod #3133

Merged
merged 5 commits into from
Jan 8, 2025

Conversation

UebelAndre
Copy link
Collaborator

No description provided.

@UebelAndre
Copy link
Collaborator Author

@keith I'm wondering if you can help me get the Android examples building again 😅

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@keith
Copy link
Member

keith commented Jan 6, 2025

it looks like the missing piece is this dropped rules_android_ndk in the MODULE.bazel which was previously in the WORKSPACE, that's what should register the toolchain

@UebelAndre UebelAndre marked this pull request as ready for review January 6, 2025 18:31
@UebelAndre UebelAndre enabled auto-merge January 6, 2025 18:31
@UebelAndre
Copy link
Collaborator Author

Thanks @keith!

@UebelAndre UebelAndre added this pull request to the merge queue Jan 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2025
@UebelAndre UebelAndre enabled auto-merge January 8, 2025 20:41
@UebelAndre UebelAndre added this pull request to the merge queue Jan 8, 2025
Merged via the queue into bazelbuild:main with commit b53f9a8 Jan 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants