Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump pip tools to >= 7.4.0 #1841

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

dougthor42
Copy link
Contributor

Bump pip_tools to >= 7.4.0 so that we can make use of better
pyproject.toml parsing error messages during compiling.

Specifically: jazzband/pip-tools#1979

@dougthor42 dougthor42 marked this pull request as ready for review April 11, 2024 18:20
@@ -21,8 +21,8 @@ _RULE_DEPS = [
# START: maintained by 'bazel run //tools/private/update_deps:update_pip_deps'
(
"pypi__build",
"https://files.pythonhosted.org/packages/58/91/17b00d5fac63d3dca605f1b8269ba3c65e98059e1fd99d00283e42a454f0/build-0.10.0-py3-none-any.whl",
"af266720050a66c893a6096a2f410989eeac74ff9a68ba194b3f6473e8e26171",
"https://files.pythonhosted.org/packages/e2/03/f3c8ba0a6b6e30d7d18c40faab90807c9bb5e9a1e3b2fe2008af624a9c97/build-1.2.1-py3-none-any.whl",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip_tools v7.4.0 (coincidentlaly, the same jazzband/pip-tools#1979 that I'm interested in using) also pinned build >= 1.0.0. In pip_tools <= 7.3.0, build did not have any version specifier.

Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the changes to the CHANGELOG.md.

@dougthor42
Copy link
Contributor Author

😱 Oops, I'm really bad at remembering to do that. Sorry! Updated.

I also noticed that there were two "Changed" sections so I merged them.

Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aignas aignas added this pull request to the merge queue Apr 18, 2024
Merged via the queue into bazelbuild:main with commit e3e8af8 Apr 18, 2024
4 checks passed
@dougthor42 dougthor42 deleted the bump-pip-tools branch April 18, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants