feat(rules): allow deriving custom rules from core rules #2666
+321
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickeylev
force-pushed
the
feat.public.builders.api
branch
from
bab485b to
153c26e
Compare
aignas
approved these changes
Mar 16, 2025
Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 20, 2025
PR #2666 forgot to add public load targets for the attr/rule builder apis and associated build targets for docs and bzl_library. --------- Co-authored-by: Richard Levasseur <rlevasseur@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes public functions for creating builders for py_binary, py_test, and py_library.
It also adds some docs and examples for how to use them.
I'm calling this a "volatile" API -- it's public, but the pieces that comprise
it (e.g. all the rule args, attributes, the attribute args, etc) are likely to change
in various ways, and not all modifications to them can be supported in a backward
compatible way. Hence the "volatile" term:
Work towards #1647