Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gazelle): Include YAML 'docstart' in gazelle manifest file #2656

Merged

Conversation

dougthor42
Copy link
Collaborator

Update gazelle_python.yaml to include the YAML docstart string:

-- a/gazelle_python.yaml
+++ b/gazelle_python.yaml
@@ -3,6 +3,7 @@
 # To update this file, run:
 #   bazel run //:gazelle_python_manifest.update
 
+---
 manifest:
   modules_mapping:
     30fcd23745efe32ce681__mypyc: black

While technically not required, it is good practice to include. And then users don't have to exclude gazelle_python.yaml from their linters 🙃.

/cc @joshgc

@dougthor42 dougthor42 marked this pull request as draft March 10, 2025 22:30
@dougthor42 dougthor42 marked this pull request as ready for review March 10, 2025 22:59
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think there may be some tests fail.

@dougthor42
Copy link
Collaborator Author

I think there may be some tests fail.

Yeah, caught the one I missed and then had to re-run for a flake (seems like this one just crashed out instead of being an actual failure)

@dougthor42 dougthor42 added this pull request to the merge queue Mar 11, 2025
Merged via the queue into bazel-contrib:main with commit 52712b9 Mar 11, 2025
4 checks passed
@dougthor42 dougthor42 deleted the u/dthor/gazelle-yaml-docstart branch March 11, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants