-
-
Notifications
You must be signed in to change notification settings - Fork 585
feat(pypi): support direct urls for wheels in bazel downloader #2655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
todo: check later if filename is necessary. Maybe not.
Thank you for the contribution.
I think this part might be good to leave for another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, I think we can correctly infer the sdist
vs not via the direct URLs, so I think its fine to just do it.
Could you please also add the CHANGELOG note about the added support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
This PR adds support for installing wheels via direct urls in the requirements lock file:
This is to improve parity between bazel downloader and pip behavior.
Before this change, direct urls used fallback to pip install.
Partially addresses #2363 as it does not add support for git urls.