feat: provide access to arbitrary interpreters #2507
Merged
+430
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run a specific interpreter: * `bazel run @rules_python//tools/run --@rules_python//python/config_settings:python_version=3.12` Run interpreter from a binary: * `bazel run @rules_python//tools/run --@rules_python//tools/run:bin=//my:binary`
$ bazel run //python/bin:repl
$ bazel run //python/bin:repl --//python/bin:repl_dep=//python/runfiles
philsc
commented
Dec 16, 2024
aignas
reviewed
Dec 16, 2024
rickeylev
requested changes
Dec 27, 2024
I noticed that my `$(location //path/to:target)` wasn't getting expanded when writing a test. This patch fixes the issue by forwarding the already-expanded environment from the inner target to the outer target.
philsc
commented
Feb 4, 2025
aignas
reviewed
Feb 10, 2025
rickeylev
reviewed
Feb 10, 2025
|
Implementation wise, I think this looks good. Just the cleanup as discussed needed |
rickeylev
approved these changes
Feb 10, 2025
|
I don't think the changes here are causing the mypy failure 🤔 |
|
re: mypy failures: Yeah, its unrelated. It started failing a couple days ago, but nobody has yet looked into why. |
|
Ah, I got a bit excited and merged this a bit soon -- CHANGELOG.md updates are missing |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 17, 2025
This was a forgotten part of the original PR (#2507) implementing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some use cases that folks want to cover here. They are
discussed in this Slack thread. The high-level summary is:
to minimize environmental issues.
so that they can use the correct interpreter.
This patch adds to @rickeylev's work from #2359 by adding docs
and a few integration tests.