-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for using Maven BOMs with Coursier #1306
Conversation
708af7d
to
b22ec5e
Compare
Had to disable dependencies from https://packages.confluent.io as the repository seems to be broken at the moment. Not sure about the remaining CI failure, as it looks to be unrelated to this change:
|
@protocol7 What seems to be the issue with the packages.confluent.io repository? Was it intermittent? |
6569c4b
to
41eb8f3
Compare
Thanks for the nudge, it seems to have been intermittent, so I now restored the test artifact from the repo. |
Coursier now support using Maven BOMs when resolving. This upgrades Coursier to 2.1.24 and enables using BOMs leveraging the existing `boms` attribute on `maven_install`. Note that Coursier has a slight performance regression since adding support for BOMs, see coursier/coursier#3190. Fixes bazel-contrib#1289
41eb8f3
to
3df0c48
Compare
Updated to Coursier 2.1.24 which fixes the last issue we've found in our internal use of the BOM support. I believe this should be ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Really nice to see that BOMs have come for the coursier
resolver too. Thank you for doing this!
This is causing a regression in our use of rules_jvm_external - we cannot upgrade to the latest release because coursier does not exist on mirror.bazel.build. |
Coursier now support using Maven BOMs when resolving. This upgrades Coursier to 2.1.24 and enables using BOMs leveraging the existing
boms
attribute onmaven_install
.Note that Coursier has a slight performance regression since adding support for BOMs, see coursier/coursier#3190.
Fixes #1289