Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using Maven BOMs with Coursier #1306

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

protocol7
Copy link
Contributor

@protocol7 protocol7 commented Jan 4, 2025

Coursier now support using Maven BOMs when resolving. This upgrades Coursier to 2.1.24 and enables using BOMs leveraging the existing boms attribute on maven_install.

Note that Coursier has a slight performance regression since adding support for BOMs, see coursier/coursier#3190.

Fixes #1289

@protocol7
Copy link
Contributor Author

Had to disable dependencies from https://packages.confluent.io as the repository seems to be broken at the moment.

Not sure about the remaining CI failure, as it looks to be unrelated to this change:

2025-01-04 15:34:59 UTC	WARNING: Couldn't auto load rules or symbols, because no dependency on module/repository 'rules_android' found. This will result in a failure if there's a reference to those rules or symbols.
2025-01-04 15:35:00 UTC	ERROR: Traceback (most recent call last):
2025-01-04 15:35:00 UTC		File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/+maven+regression_testing_coursier/BUILD", line 48, column 11, in <toplevel>
2025-01-04 15:35:00 UTC			aar_import(
2025-01-04 15:35:00 UTC	Error in aar_import: Couldn't auto load 'aar_import' from '@rules_android//rules:rules.bzl'.

@vinnybod
Copy link
Contributor

@protocol7 What seems to be the issue with the packages.confluent.io repository? Was it intermittent?

@protocol7
Copy link
Contributor Author

@protocol7 What seems to be the issue with the packages.confluent.io repository? Was it intermittent?

Thanks for the nudge, it seems to have been intermittent, so I now restored the test artifact from the repo.

Coursier now support using Maven BOMs when resolving. This upgrades
Coursier to 2.1.24 and enables using BOMs leveraging the existing `boms`
attribute on `maven_install`.

Note that Coursier has a slight performance regression since adding
support for BOMs, see coursier/coursier#3190.

Fixes bazel-contrib#1289
@protocol7
Copy link
Contributor Author

protocol7 commented Jan 18, 2025

Updated to Coursier 2.1.24 which fixes the last issue we've found in our internal use of the BOM support. I believe this should be ready for review now.

Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Really nice to see that BOMs have come for the coursier resolver too. Thank you for doing this!

@shs96c shs96c merged commit 3289580 into bazel-contrib:master Feb 6, 2025
7 checks passed
@protocol7 protocol7 deleted the boms-with-coursier branch February 6, 2025 15:11
@peakschris
Copy link

This is causing a regression in our use of rules_jvm_external - we cannot upgrade to the latest release because coursier does not exist on mirror.bazel.build.

#1329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Allow BOM resolution with the Coursier resolver
4 participants