Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk: remove logic for Bazel versions below 6.4.0 #4238

Merged

Conversation

sluongng
Copy link
Contributor

Before 6.4.0, there is a bug in Bazel when extracting archive with
special file names inside.

Since Bazel 6 is not the oldest supported LTS and 6.5.0 is already
released, we should be able to remove this logic safely.

Before 6.4.0, there is a bug in Bazel when extracting archive with
special file names inside.

Since Bazel 6 is not the oldest supported LTS and 6.5.0 is already
released, we should be able to remove this logic safely.
@sluongng
Copy link
Contributor Author

Also relevant

# go/private/common.bzl:156
MINIMUM_BAZEL_VERSION = "6.5.0"

Copy link
Member

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So happy about this being gone :-)

Could you drop lines 423 + 424 to please buildifier?

@fmeum fmeum enabled auto-merge (squash) January 21, 2025 16:03
auto-merge was automatically disabled January 22, 2025 13:51

Head branch was pushed to by a user without write access

@sluongng
Copy link
Contributor Author

@fmeum could you hit the green button? 😄

@fmeum fmeum merged commit 7f6a9bf into bazel-contrib:master Jan 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants