refactor: simplify walk configuration, func signatures #1932
+12
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
changed the title
jbedard
force-pushed
the
param-simplify
branch
from
9e5e657 to
f1776f2
Compare
fmeum
reviewed
Oct 23, 2024
jbedard
force-pushed
the
param-simplify
branch
from
f1776f2 to
0263874
Compare
|
Lets also do #1931 first. |
jbedard
force-pushed
the
param-simplify
branch
2 times, most recently
from
a89dca2 to
e7f69b4
Compare
I take that back. I think this is worth merging as-is for now 🤷 |
fmeum
approved these changes
Dec 13, 2024
fmeum
reviewed
Dec 13, 2024
fmeum
force-pushed
the
param-simplify
branch
from
e7f69b4 to
b173bca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What package or component does this PR mostly affect?
What does this PR do? Why is it needed?
Minor refactoring which will make further improvements easier.