Use logo_url instead of "logo", removed in Sphinx 6 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit sphinx-doc/sphinx@ac0fc4b78173 ("Remove more deprecated items in Sphinx 6.0 (#10562)"), Sphinx removed the deprecated variables "logo" and "favicon", in favour of "logo_url" and "favicon_url", respectively. As a consequence, including the logo defined in "html_logo" no longer works when the sphinx_material theme is used with Sphinx >= 6. Let's use logo_url if available in header.html. We also use it in sidebar.html, although this one doesn't matter much because CSS class md-nav__button gets a "display:none" in application.css.
|
As a side note (and not related to this PR), I'd be curious to understand how file |
|
Hi, is there anything I can do to help the PR move forward? |
|
We are also silently affected by this, glad that you found a solution @Qeole 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit sphinx-doc/sphinx@ac0fc4b78173 (
Remove more deprecated items in Sphinx 6.0 (#10562)), Sphinx removed the deprecated variableslogoandfavicon, in favour oflogo_urlandfavicon_url, respectively. As a consequence, including the logo defined inhtml_logono longer works when the sphinx_material theme is used with Sphinx >= 6.Let's use
logo_urlif available in header.html. We also use it in sidebar.html, although this one doesn't matter much because CSS classmd-nav__buttongets adisplay:nonein application.css.