Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Model's --write duplicates array properties #1594

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

KentarouTakeda
Copy link
Contributor

@KentarouTakeda KentarouTakeda commented Oct 17, 2024

Summary

Thanks for merging barryvdh/ReflectionDocBlock#17. This pull request closes #1505

Now that the new version has been published:

  • Use the new corrected version for testing, including the prefer-lowest tests
  • Fix the tests that were marked as incorrect to be correct

I've made the above changes.

Type of change

  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
kostasrim Kostas Kyrimis

Verified

This commit was signed with the committer’s verified signature.
kostasrim Kostas Kyrimis
@KentarouTakeda
Copy link
Contributor Author

Some tests that are still failing are unrelated to this pull request.

Yesterday's scheduled tests caused many to "correctly" fail due to the upstream fix.

This pull request will make those failures succeed correctly.

Please review the test results before and after the fix if necessary.

test-results-before-and-after-fix

@barryvdh barryvdh merged commit d3965aa into barryvdh:master Oct 17, 2024
22 of 26 checks passed
@KentarouTakeda KentarouTakeda deleted the gh-1505 branch October 17, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model's --write duplicates array properties that have summary and array key-value types added
2 participants