🐛 Add tie breaker when sorting changesets by RevisionID in tests. (os…

…sf#2781)

* Remove duplicate RevisionID collision from changeset tests.

The map iteration order isn't deterministic and sorting the slices isn't good enough when the revision IDs are equal.

Signed-off-by: Spencer Schrock <sschrock@google.com>

* remove any potential sha collisions

Signed-off-by: Spencer Schrock <sschrock@google.com>

* Revert deduplications.

Signed-off-by: Spencer Schrock <sschrock@google.com>

* Use ReviewPlatform as tie breaker.

Signed-off-by: Spencer Schrock <sschrock@google.com>

---------

Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Avishay <avishay.balter@gmail.com>

checks/raw/code_review_test.go

@@ -358,6 +358,9 @@ func Test_getChangesets(t *testing.T) {
 		changesets := getChangesets(tt.commits)
 		if !cmp.Equal(tt.expected, changesets,
 			cmpopts.SortSlices(func(x, y checker.Changeset) bool {
+				if x.RevisionID == y.RevisionID {
+					return x.ReviewPlatform < y.ReviewPlatform
+				}
 				return x.RevisionID < y.RevisionID
 			}),
 			cmpopts.SortSlices(func(x, y clients.Commit) bool {