-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for plugin-proposal-json-modules #2866
Add docs for plugin-proposal-json-modules #2866
Conversation
✅ Deploy Preview for babel-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for babel ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add sidebar items to
Line 241 in 773314d
"TC39 Proposals": [ |
We can split the group into "stage 3" and "early" as well.
docs/plugin-proposal-json-modules.md
Outdated
</TabItem> | ||
<TabItem value="node-esm" label="Node.js (ESM)"> | ||
|
||
```js title="output.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
```js title="output.js" | |
```js title="output.mjs" |
will be transformed to | ||
|
||
<Tabs> | ||
<TabItem value="browsers" label="Browsers" default> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the preface mentions that "whether the generated code should be compatible with Node.js, browsers, or both", can you add a tab here to show the output when targeting both platforms?
Docs for babel/babel#16172
Preview: https://deploy-preview-2866--babel-next.netlify.app/docs/babel-plugin-proposal-json-modules