Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from gulp-util #137

Merged
merged 1 commit into from
Jan 26, 2018
Merged

Migrate away from gulp-util #137

merged 1 commit into from
Jan 26, 2018

Conversation

phated
Copy link
Contributor

@phated phated commented Dec 22, 2017

gulp-util is deprecated and is gigantic. This reduces size of package download and fixes some out-of-date dependency problems.

@demurgos
Copy link
Member

demurgos commented Jan 1, 2018

@hzoo @sindresorhus
Could you merge and publish this PR?

@demurgos
Copy link
Member

Pinging this PR: gulp-babel is one of the most popular Gulp plugins, it is important to keep its dependencies up to date.

@phated
Copy link
Contributor Author

phated commented Jan 23, 2018

@hzoo is this module unmaintained? Would you be willing to hand it off to another maintainer?

@ghost
Copy link

ghost commented Jan 23, 2018

@phated
Copy link
Contributor Author

phated commented Jan 23, 2018

@pgnd thanks, that's why I suggested someone else take this. The gulp ecosystem needs this maintained (it's the most downloaded plugin).

@hzoo
Copy link
Member

hzoo commented Jan 24, 2018

@phated I can give you merge/publish if you want but I think we'd also probably want to backport to 6.x for this to be effective for the current users? (ok done so you can merge/publish)

Don't know if it's confusing but there is the current 6.x release line, 7.0.0 which uses babel-core with a peerDep and then v8.0.0-beta.0 which uses @babel/core. I would probably find the last 6.x commit and make a 6.x branch and then publish a similar patch from there.

v7 is still in beta and we weren't sure we were going to use scoped packages so that's why the different versions. Maybe there is an argument for just doing a 7.0.1 patch for @babel/core so it seems like the same version but it's non semver.

@phated
Copy link
Contributor Author

phated commented Jan 24, 2018

@hzoo thanks! It's probably better to give @demurgos permissions since he is leading the ecosystem migration

@demurgos
Copy link
Member

demurgos commented Jan 24, 2018

@hzoo
I am not very familiar with babel so I may not be able to fix issues depending on the details of babel, but I'd be happy to help with maintenance regarding the gulp parts.

Edit: Thanks for the invite. I'll try to find some time this week to work on this.

@demurgos demurgos mentioned this pull request Jan 26, 2018
@demurgos demurgos merged commit 8444334 into babel:master Jan 26, 2018
@demurgos
Copy link
Member

Merged.
I'll backport this update to the releases 7.x and 6.x, clean-up a few things and push it to npm.

demurgos added a commit to demurgos/gulp-babel that referenced this pull request Jan 26, 2018
demurgos added a commit that referenced this pull request Jan 26, 2018
@demurgos demurgos mentioned this pull request Jan 26, 2018
demurgos added a commit to demurgos/gulp-babel that referenced this pull request Jan 26, 2018
@demurgos demurgos mentioned this pull request Jan 26, 2018
demurgos added a commit to demurgos/gulp-babel that referenced this pull request Jan 26, 2018
demurgos added a commit to demurgos/gulp-babel that referenced this pull request Jan 26, 2018
demurgos added a commit to demurgos/gulp-babel that referenced this pull request Jan 26, 2018
- **[Fix]** Drop dependency on deprecated `gulp-util`
  ([babel#137](babel#137))
- **[Chore]** Update repository: add `CHANGELOG.md`,
  update `.gitignore`, license year, update dependencies, add lock
  files, add _npm_ badge, mention `gulp-babel@next`.
@demurgos demurgos mentioned this pull request Jan 26, 2018
@demurgos
Copy link
Member

demurgos commented Jan 26, 2018

All the versions were published to npm:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants