Ensure the worker processes do not crash when parsing invalid syntax #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code **never** handled the cases where `@babel/core`'s
`transform` method throws an error, it just _happened_ to be that we
didn't hit this case (because babel tended not to `throw` during
parsing).
This updates to ensure that our worker will always resolve, sometimes
with `{ code, metadata }` and other times (when an error happens)
`{ error, stack }`. When we resolve with `{ error, stack }` the parent
process will throw an error with that information (so that `ember build`
exits non-zero, or `ember serve` shows the build failure and then
rebuilds succesfully once the syntax error is fixed).
rwjblue
force-pushed
the
fix-syntax-error-handling
branch
from
8b3f7c5
to
91d7826
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code never handled the cases where
@babel/core'stransformmethod throws an error, it just happened to be that we didn't hit this case (because babel tended not tothrowduring parsing).This updates to ensure that our worker will always resolve, sometimes with
{ code, metadata }and other times (when an error happens){ error, stack }. When we resolve with{ error, stack }the parent process will throw an error with that information (so thatember buildexits non-zero, orember serveshows the build failure and then rebuilds succesfully once the syntax error is fixed).