Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duplicate-named-capturing-groups-regex to preset-env #16445

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Apr 24, 2024

Q                       A
Fixed Issues? Add duplicate-named-capturing-groups-regex to preset-env as the language will be included in ES2025
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link babel/website#2893
Any Dependency Changes?
License MIT
  • Renmae plugin to transform-*
  • Add it to preset-env

@JLHwung JLHwung added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: preset-env labels Apr 24, 2024
@JLHwung JLHwung added this to the v7.25.0 milestone Apr 24, 2024
@JLHwung JLHwung force-pushed the add-duplicate-named-capturing-groups-regex branch from ee6b37a to fb04bfe Compare April 24, 2024 16:53
@babel-bot
Copy link
Collaborator

babel-bot commented Apr 24, 2024

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57075

@JLHwung JLHwung force-pushed the add-duplicate-named-capturing-groups-regex branch from fb04bfe to 8290a7e Compare April 24, 2024 16:58
@JLHwung JLHwung force-pushed the add-duplicate-named-capturing-groups-regex branch from 8290a7e to 4daa034 Compare May 29, 2024 03:25
@JLHwung JLHwung marked this pull request as ready for review May 29, 2024 06:11
@JLHwung
Copy link
Contributor Author

JLHwung commented May 29, 2024

The CI error is related. As duplicate-named-capturing-groups-regex requires babel-core 7.19, preset-env will also indirectly require babel-core 7.19+. This case is similar to the class-static-block transform which requires babel-core 7.12 and was added to preset-env in 7.16.

I tend to revise the regression test so that it works for Babel <7.13.

@nicolo-ribaudo
Copy link
Member

Isn't adding it to minVersions enough (

Object.assign(minVersions, {
"bugfix/transform-safari-id-destructuring-collision-in-function-expression":
"7.16.0",
"bugfix/transform-v8-static-class-fields-redefine-readonly": "7.12.0",
"syntax-import-attributes": "7.22.0",
"transform-class-static-block": "7.12.0",
"transform-private-property-in-object": "7.10.0",
});
)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: preset-env PR: New Feature 🚀 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants