Fix optional chain optimization in sequence expression #15888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Bug Fix 🐛
nicolo-ribaudo
commented
Aug 24, 2023
| (t.isExpressionStatement(replacementPath.parent) && | ||
| !replacementPath.isCompletionRecord()) || | ||
| (t.isSequenceExpression(replacementPath.parent) && | ||
| last(replacementPath.parent.expressions) !== replacementPath.node); |
There was a problem hiding this comment.
It might make sense to have a path.isValueObservable() helper eventually.
There was a problem hiding this comment.
It certainly reminds me of the messy path._getCompletionRecords. Thankfully the switch statement is not an expression.
There was a problem hiding this comment.
Similar usage:
babel/packages/babel-plugin-proposal-destructuring-private/src/index.ts
Lines 162 to 164 in c71a217
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55206/ |
liuxingbaoyu
approved these changes
Aug 25, 2023
|
Releasing a patch to fix the regression. |
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that
isCompletionRecordin the test code is returning false, because the sequence expression was not in a completion record position.