Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix importing symbol polyfill in @babel/runtime-corejs2 #15660

Merged

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented May 26, 2023

Q                       A
Fixed Issues? Fixes #15659
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

The actual fix is in babel/babel-polyfills#162

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories i: regression labels May 26, 2023
@babel-bot
Copy link
Collaborator

babel-bot commented May 26, 2023

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54548/

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54546/

@nicolo-ribaudo nicolo-ribaudo merged commit 9e3ea11 into babel:main May 26, 2023
54 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the update-babel-plugin-polyfill-corejs2 branch May 26, 2023 17:43
@nicolo-ribaudo
Copy link
Member Author

Releasing now

@@ -1,6 +1,6 @@
import _regeneratorRuntime from "@babel/runtime-corejs2/helpers/regeneratorRuntime";
var _marked = /*#__PURE__*/_regeneratorRuntime().mark(giveWord);
import _Symbol from "@babel/runtime-corejs2/core-js/symbol";
import _Symbol from "@babel/runtime-corejs2/core-js/symbol/index";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be some issues here.🤦‍♂️
This appears to be an invalid path.

image
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ushhh thanks for catching this

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: 7.22.0 introduces failure to find modules
3 participants