Fix problems found while publishing 7.21.0 #15440
Conversation
| @@ -230,4 +230,4 @@ type ParseResult<Result> = Result & { | |||
| errors: ParseError[]; | |||
| }; | |||
|
|
|||
| export { DecoratorsPluginOptions, FlowPluginOptions, ParseError, ParserOptions, ParserPlugin, ParserPluginWithOptions, PipelineOperatorPluginOptions, RecordAndTuplePluginOptions, TypeScriptPluginOptions, parse, parseExpression, tokTypes }; | |||
| export { DecoratorsPluginOptions, FlowPluginOptions, ParseError, ParseResult, ParserOptions, ParserPlugin, ParserPluginWithOptions, PipelineOperatorPluginOptions, RecordAndTuplePluginOptions, TypeScriptPluginOptions, parse, parseExpression, tokTypes }; | |||
There was a problem hiding this comment.
This is a regression, for some reason the file published in 7.21.0 didn't include ParseResult.
|
These look like warnings, and I think the real failure reason has to do with |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53991/ |
|
https://github.com/babel/babel/pull/14572/files#diff-10d032f00c2fe160bd8376108cca5a4c66d73998c3a47008f89e58eae5ea1356 |
liuxingbaoyu
added
pkg: parser
PR: Bug Fix 🐛
| * By default, new.target use is not allowed outside of a function or class. | ||
| * Set this to true to accept such code. | ||
| */ | ||
| allowNewTargetOutsideFunction?: boolean; |
There was a problem hiding this comment.
Good catch! Let's add annexB together.
|
I'm trying to reproduce the original failure locally. |
|
I tried |
|
Whoops, I just remembered. Probably because github's terminal doesn't fully support colors, I remember this was fixed in newer dependencies, but we don't seem to be updating it because of babel8. But I don't understand why CI throws exception only when publishing. |
|
Ohh I got it.
I'll add back |
|
Also I found that |
github-actions
bot
added
the
outdated
Fixes #1, Fixes #2I had to manually release 7.21.0 because these problems made CI fail (https://github.com/babel/babel/actions/runs/4224580190/jobs/7335726019)