Merge branch 'main' into improve-using

babel · Dec 28, 2023 · f98d8d3 · f98d8d3
2 parents d58b250 + 365aa94
commit f98d8d3
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 11 deletions.
diff --git a/eslint.config.js b/eslint.config.js
@@ -88,7 +88,7 @@ module.exports = [
           parser: parserTypeScriptESLint,
           parserOptions: {
             allowAutomaticSingleRunInference: true,
-            project: "./tsconfig.eslint.json",
+            EXPERIMENTAL_useProjectService: true,
           },
         },
         plugins: {

diff --git a/packages/babel-helpers/src/helpers/setFunctionName.ts b/packages/babel-helpers/src/helpers/setFunctionName.ts
@@ -8,7 +8,7 @@ export default function setFunctionName<T extends Function>(
 ): T {
   if (typeof name === "symbol") {
     name = name.description;
-    name = name ? "[" + (name as string) + "]" : "";
+    name = name ? "[" + name + "]" : "";
   }
   // In some older browsers .name was non-configurable, here we catch any
   // errors thrown by defineProperty.

diff --git a/packages/babel-plugin-proposal-import-defer/src/index.ts b/packages/babel-plugin-proposal-import-defer/src/index.ts
@@ -95,7 +95,7 @@ export default declare(api => {
             (child.isExportNamedDeclaration() && child.node.source !== null) ||
             child.isExportAllDeclaration()
           ) {
-            const specifier = child.node.source!.value;
+            const specifier = child.node.source.value;
             if (!eagerImports.has(specifier)) {
               eagerImports.add(specifier);
             }

diff --git a/packages/babel-traverse/src/path/removal.ts b/packages/babel-traverse/src/path/removal.ts
@@ -30,8 +30,10 @@ export function _removeFromScope(this: NodePath) {
 }
 
 export function _callRemovalHooks(this: NodePath) {
-  for (const fn of hooks) {
-    if (fn(this, this.parentPath)) return true;
+  if (this.parentPath) {
+    for (const fn of hooks) {
+      if (fn(this, this.parentPath)) return true;
+    }
   }
 }
 

diff --git a/packages/babel-traverse/test/removal.js b/packages/babel-traverse/test/removal.js
@@ -152,4 +152,17 @@ describe("removal", function () {
 
     expect(rootPath.scope.hasBinding("x")).toBe(true);
   });
+
+  it("should not throw when removing without `Program`", function () {
+    const ast = parse("['1']").program.body[0].expression;
+
+    traverse(ast, {
+      noScope: true,
+      StringLiteral(path) {
+        path.remove();
+      },
+    });
+
+    expect(ast.elements.length).toBe(0);
+  });
 });
diff --git a/tsconfig.eslint.json b/tsconfig.eslint.json