Enable Babel and Prettier e2e tests for the esm build (#15672)

* Try enabling more e2e tests for the esm build * ssh * babel, cra, prettier * Dont load babel config in ESLint tests * Add missing devdep used in tests * Make sure to not load root babel.config.js in tests * syntax old node
babel · Jun 26, 2023 · ef1cddb · ef1cddb
1 parent 04f063e
commit ef1cddb
Show file tree

Hide file tree

Showing 7 changed files with 37 additions and 10 deletions.
diff --git a/.github/workflows/e2e-tests-esm.yml b/.github/workflows/e2e-tests-esm.yml
@@ -44,7 +44,9 @@ jobs:
       fail-fast: false
       matrix:
         project:
+          - babel
           - create-react-app
+          - prettier
     steps:
       - name: Get yarn1 cache directory path
         id: yarn1-cache-dir-path
@@ -82,5 +84,3 @@ jobs:
           path: /tmp/verdaccio-workspace
       - name: Test
         run: ./scripts/integration-tests/e2e-${{ matrix.project }}.sh
-        env:
-          USE_ESM: true
diff --git a/babel.config.js b/babel.config.js
@@ -1,5 +1,9 @@
 "use strict";
 
+if (typeof it === "function") {
+  throw new Error("Monorepo root's babel.config.js loaded by a test.");
+}
+
 const pathUtils = require("path");
 const fs = require("fs");
 const { parseSync } = require("@babel/core");

diff --git a/eslint/babel-eslint-parser/test/index.js b/eslint/babel-eslint-parser/test/index.js
@@ -3,9 +3,20 @@ import escope from "eslint-scope";
 import unpad from "dedent";
 import { fileURLToPath } from "url";
 import { createRequire } from "module";
-import { parseForESLint } from "../lib/index.cjs";
+import { parseForESLint as parseForESLintOriginal } from "../lib/index.cjs";
 import { ESLint } from "eslint";
 
+function parseForESLint(code, options) {
+  return parseForESLintOriginal(code, {
+    requireConfigFile: false,
+    ...options,
+    babelOptions: {
+      configFile: false,
+      ...options.babelOptions,
+    },
+  });
+}
+
 const ESLINT_VERSION = ESLint.version;
 const isESLint7 = ESLINT_VERSION.startsWith("7.");
 const dirname = path.dirname(fileURLToPath(import.meta.url));

diff --git a/eslint/babel-eslint-tests/test/helpers/verifyAndAssertMessages.js b/eslint/babel-eslint-tests/test/helpers/verifyAndAssertMessages.js
@@ -25,13 +25,16 @@ export default function verifyAndAssertMessages(
     parserOptions: {
       sourceType,
       requireConfigFile: false,
+      ...(overrideConfig && overrideConfig.parserOptions),
       babelOptions: {
         configFile: path.resolve(
           path.dirname(fileURLToPath(import.meta.url)),
           "../../../babel-eslint-shared-fixtures/config/babel.config.js",
         ),
+        ...(overrideConfig &&
+          overrideConfig.parserOptions &&
+          overrideConfig.parserOptions.babelOptions),
       },
-      ...(overrideConfig && overrideConfig.parserOptions),
     },
   });
 

diff --git a/packages/babel-node/package.json b/packages/babel-node/package.json
@@ -36,6 +36,7 @@
   "devDependencies": {
     "@babel/core": "workspace:^",
     "@babel/helper-fixtures": "workspace:^",
+    "@babel/preset-env": "workspace:^",
     "@babel/runtime": "workspace:^",
     "@types/v8flags": "^3.1.1",
     "fs-readdir-recursive": "^1.0.0",

diff --git a/packages/babel-plugin-transform-optional-chaining/test/util.skip-bundled.js b/packages/babel-plugin-transform-optional-chaining/test/util.skip-bundled.js
@@ -3,13 +3,20 @@ import { parseSync, traverse } from "@babel/core";
 
 function getPath(input, parserOpts) {
   let targetPath;
-  traverse(parseSync(input, { parserOpts, filename: "example.js" }), {
-    OptionalMemberExpression(path) {
-      targetPath = path;
-      path.stop();
+  traverse(
+    parseSync(input, {
+      parserOpts,
+      filename: "example.js",
+      configFile: false,
+    }),
+    {
+      OptionalMemberExpression(path) {
+        targetPath = path;
+        path.stop();
+      },
+      noScope: true,
     },
-    noScope: true,
-  });
+  );
   return targetPath;
 }
 

diff --git a/yarn.lock b/yarn.lock
@@ -1082,6 +1082,7 @@ __metadata:
   dependencies:
     "@babel/core": "workspace:^"
     "@babel/helper-fixtures": "workspace:^"
+    "@babel/preset-env": "workspace:^"
     "@babel/register": "workspace:^"
     "@babel/runtime": "workspace:^"
     "@types/v8flags": ^3.1.1