review

babel · Dec 5, 2023 · c7804e8 · c7804e8
1 parent 8a2da65
commit c7804e8
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/packages/babel-plugin-transform-for-of/package.json b/packages/babel-plugin-transform-for-of/package.json
@@ -17,7 +17,8 @@
     "babel-plugin"
   ],
   "dependencies": {
-    "@babel/helper-plugin-utils": "workspace:^"
+    "@babel/helper-plugin-utils": "workspace:^",
+    "@babel/helper-skip-transparent-expression-wrappers": "workspace:^"
   },
   "peerDependencies": {
     "@babel/core": "^7.0.0-0"

diff --git a/packages/babel-plugin-transform-for-of/src/index.ts b/packages/babel-plugin-transform-for-of/src/index.ts
@@ -3,6 +3,7 @@ import { template, types as t } from "@babel/core";
 import type { NodePath } from "@babel/traverse";
 
 import transformWithoutHelper from "./no-helper-implementation.ts";
+import { skipTransparentExprWrapperNodes } from "@babel/helper-skip-transparent-expression-wrappers";
 
 export interface Options {
   allowArrayLike?: boolean;
@@ -89,10 +90,14 @@ export default declare((api, options: Options) => {
       visitor: {
         ForOfStatement(path) {
           const { scope } = path;
-          const { left, right, await: isAwait } = path.node;
+          const { left, await: isAwait } = path.node;
           if (isAwait) {
             return;
           }
+          // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
+          const right = skipTransparentExprWrapperNodes(
+            path.node.right,
+          ) as t.Expression;
           const i = scope.generateUidIdentifier("i");
           let array: t.Identifier | t.ThisExpression =
             scope.maybeGenerateMemoised(right, true);

diff --git a/yarn.lock b/yarn.lock
@@ -2724,6 +2724,7 @@ __metadata:
     "@babel/core": "workspace:^"
     "@babel/helper-plugin-test-runner": "workspace:^"
     "@babel/helper-plugin-utils": "workspace:^"
+    "@babel/helper-skip-transparent-expression-wrappers": "workspace:^"
   peerDependencies:
     "@babel/core": ^7.0.0-0
   languageName: unknown