fix: transform-block-scoping captures the variables of the method i…

…n the loop (#15962)

fix

packages/babel-plugin-transform-block-scoping/src/loop.ts

@@ -75,7 +75,9 @@ function relativeLoopLocation(path: NodePath, loopPath: NodePath<t.Loop>) {
   let inClosure = false;
 
   for (let currPath = path; currPath; currPath = currPath.parentPath) {
-    if (currPath.isFunction() || currPath.isClass()) inClosure = true;
+    if (currPath.isFunction() || currPath.isClass() || currPath.isMethod()) {
+      inClosure = true;
+    }
     if (currPath === bodyPath) {
       return { inBody: true, inClosure };
     } else if (currPath === loopPath) {

packages/babel-plugin-transform-block-scoping/test/fixtures/general/loop-closure-in-method/exec.js

@@ -0,0 +1,15 @@
+var objects = [];
+var i2 = 0;
+for (var i = 0; i < 10; i++) {
+  let captured = i2;
+  i2++;
+
+  objects.push({
+    foo() {
+      return captured;
+    }
+  });
+}
+
+expect(objects[0].foo()).toBe(0);
+expect(objects[1].foo()).toBe(1);

packages/babel-plugin-transform-block-scoping/test/fixtures/general/loop-closure-in-method/input.js

@@ -0,0 +1,15 @@
+var objects = [];
+var i2 = 0;
+for (var i = 0; i < 10; i++) {
+  let captured = i2;
+  i2++;
+
+  objects.push({
+    foo() {
+      return captured;
+    }
+  });
+}
+
+expect(objects[0].foo()).toBe(0);
+expect(objects[1].foo()).toBe(1);

packages/babel-plugin-transform-block-scoping/test/fixtures/general/loop-closure-in-method/output.js

@@ -0,0 +1,16 @@
+var objects = [];
+var i2 = 0;
+var _loop = function () {
+  var captured = i2;
+  i2++;
+  objects.push({
+    foo() {
+      return captured;
+    }
+  });
+};
+for (var i = 0; i < 10; i++) {
+  _loop();
+}
+expect(objects[0].foo()).toBe(0);
+expect(objects[1].foo()).toBe(1);