[eslint] Fix no-use-before-define for class ref in fields (#16210)

babel · Jan 11, 2024 · 5540310 · 5540310
1 parent 022a334
commit 5540310
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 2 deletions.
diff --git a/eslint/babel-eslint-parser/src/analyze-scope.cjs b/eslint/babel-eslint-parser/src/analyze-scope.cjs
@@ -213,8 +213,30 @@ class Referencer extends OriginalReferencer {
   }
 
   _visitClassProperty(node) {
-    this._visitTypeAnnotation(node.typeAnnotation);
-    this.visitProperty(node);
+    const { computed, key, typeAnnotation, value } = node;
+
+    if (computed) this.visit(key);
+    this._visitTypeAnnotation(typeAnnotation);
+
+    if (value) {
+      if (this.scopeManager.__nestClassFieldInitializerScope) {
+        this.scopeManager.__nestClassFieldInitializerScope(value);
+      } else {
+        // Given that ESLint 7 didn't have a "class field initializer" scope,
+        // we create a plain method scope. Semantics are the same.
+        this.scopeManager.__nestScope(
+          new Scope(
+            this.scopeManager,
+            "function",
+            this.scopeManager.__currentScope,
+            value,
+            true,
+          ),
+        );
+      }
+      this.visit(value);
+      this.close(value);
+    }
   }
 
   _visitDeclareX(node) {

diff --git a/eslint/babel-eslint-tests/test/integration/eslint/verify.js b/eslint/babel-eslint-tests/test/integration/eslint/verify.js
@@ -1749,6 +1749,17 @@ describe("verify", () => {
           { "no-unused-vars": 1 },
         );
       });
+
+      it("no-use-before-define allows referencing the class in a field", () => {
+        verifyAndAssertMessages(
+          `
+            class C {
+              d = C.name;
+            }
+          `,
+          { "no-use-before-define": 1 },
+        );
+      });
     });
 
     describe("private field declarations", () => {
@@ -1774,6 +1785,17 @@ describe("verify", () => {
         );
       });
 
+      it("no-use-before-define allows referencing the class in a field", () => {
+        verifyAndAssertMessages(
+          `
+            class C {
+              #d = C.name;
+            }
+          `,
+          { "no-use-before-define": 1 },
+        );
+      });
+
       it("type annotations should work", () => {
         verifyAndAssertMessages(
           `class C {