optional assign is not in general an lval (e.g. no [a?.b]=c)

babel · Aug 2, 2023 · 3311711 · 3311711
1 parent a3202e1
commit 3311711
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 8 deletions.
diff --git a/packages/babel-types/src/ast-types/generated/index.ts b/packages/babel-types/src/ast-types/generated/index.ts
@@ -311,7 +311,7 @@ export interface ArrayExpression extends BaseNode {
 export interface AssignmentExpression extends BaseNode {
   type: "AssignmentExpression";
   operator: string;
-  left: LVal;
+  left: LVal | OptionalMemberExpression;
   right: Expression;
 }
 
@@ -2406,7 +2406,6 @@ export type LVal =
   | AssignmentPattern
   | ArrayPattern
   | ObjectPattern
-  | OptionalMemberExpression
   | TSParameterProperty
   | TSAsExpression
   | TSSatisfiesExpression
@@ -5788,7 +5787,6 @@ export interface ParentMaps {
     | UnionTypeAnnotation;
   OptionalMemberExpression:
     | ArrayExpression
-    | ArrayPattern
     | ArrowFunctionExpression
     | AssignmentExpression
     | AssignmentPattern
@@ -5824,7 +5822,6 @@ export interface ParentMaps {
     | ParenthesizedExpression
     | PipelineBareFunction
     | PipelineTopicExpression
-    | RestElement
     | ReturnStatement
     | SequenceExpression
     | SpreadElement

diff --git a/packages/babel-types/src/builders/generated/index.ts b/packages/babel-types/src/builders/generated/index.ts
@@ -15,7 +15,7 @@ export function arrayExpression(
 }
 export function assignmentExpression(
   operator: string,
-  left: t.LVal,
+  left: t.LVal | t.OptionalMemberExpression,
   right: t.Expression,
 ): t.AssignmentExpression {
   return validateNode<t.AssignmentExpression>({

diff --git a/packages/babel-types/src/definitions/core.ts b/packages/babel-types/src/definitions/core.ts
@@ -63,10 +63,11 @@ defineType("AssignmentExpression", {
     },
     left: {
       validate: !process.env.BABEL_TYPES_8_BREAKING
-        ? assertNodeType("LVal")
+        ? assertNodeType("LVal", "OptionalMemberExpression")
         : assertNodeType(
             "Identifier",
             "MemberExpression",
+            "OptionalMemberExpression",
             "ArrayPattern",
             "ObjectPattern",
             "TSAsExpression",
@@ -2176,7 +2177,7 @@ defineType("ExportNamespaceSpecifier", {
 defineType("OptionalMemberExpression", {
   builder: ["object", "property", "computed", "optional"],
   visitor: ["object", "property"],
-  aliases: ["Expression", "LVal"],
+  aliases: ["Expression"],
   fields: {
     object: {
       validate: assertNodeType("Expression"),

diff --git a/packages/babel-types/src/validators/generated/index.ts b/packages/babel-types/src/validators/generated/index.ts
@@ -3162,7 +3162,6 @@ export function isLVal(
     case "AssignmentPattern":
     case "ArrayPattern":
     case "ObjectPattern":
-    case "OptionalMemberExpression":
     case "TSParameterProperty":
     case "TSAsExpression":
     case "TSSatisfiesExpression":