Skip to content

Commit

Permalink
remove semver dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
JLHwung committed Jul 4, 2023
1 parent c016668 commit 2dc6f8d
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 25 deletions.
3 changes: 1 addition & 2 deletions packages/babel-standalone/package.json
Expand Up @@ -113,8 +113,7 @@
"@babel/preset-react": "workspace:^",
"@babel/preset-typescript": "workspace:^",
"acorn": "^8.7.0",
"jsdom": "^22.1.0",
"semver": "^6.3.0"
"jsdom": "^22.1.0"
},
"keywords": [
"babel",
Expand Down
47 changes: 25 additions & 22 deletions packages/babel-standalone/test/transform-script-tags.test.js
@@ -1,11 +1,11 @@
import fs from "fs";
import { createRequire } from "module";
import semver from "semver";
import { itGte } from "$repo-utils";
const require = createRequire(import.meta.url);

const nodeGte16 = semver.gte(process.version, "16.0.0");
const nodeGte16 = itGte("16.0.0");

(nodeGte16 ? describe : describe.skip)("transformScriptTags", () => {
describe("transformScriptTags", () => {
let standaloneSource;
let JSDOM;
beforeAll(async () => {
Expand All @@ -15,7 +15,7 @@ const nodeGte16 = semver.gte(process.version, "16.0.0");
);
JSDOM = require("jsdom").JSDOM;
});
it("should transform script element with type 'text/babel'", () => {
nodeGte16("should transform script element with type 'text/babel'", () => {
const dom = new JSDOM(
`<!DOCTYPE html><head><script>${standaloneSource}</script><script type="text/babel">globalThis ?? window</script></head>`,
{ runScripts: "dangerously" },
Expand All @@ -36,24 +36,27 @@ const nodeGte16 = semver.gte(process.version, "16.0.0");
});
});
});
it("should pass through the nonce attribute to the transformed script element", () => {
const nonceAttribute = "nonce_example";
nodeGte16(
"should pass through the nonce attribute to the transformed script element",
() => {
const nonceAttribute = "nonce_example";

const dom = new JSDOM(
`<!DOCTYPE html><head><script>${standaloneSource}</script><script type="text/babel" nonce="${nonceAttribute}">globalThis ?? window</script></head>`,
{ runScripts: "dangerously" },
);
return new Promise((resolve, reject) => {
dom.window.addEventListener("DOMContentLoaded", () => {
try {
const transformedScriptElement =
dom.window.document.head.children.item(2);
expect(transformedScriptElement.nonce).toBe(nonceAttribute);
resolve();
} catch (err) {
reject(err);
}
const dom = new JSDOM(
`<!DOCTYPE html><head><script>${standaloneSource}</script><script type="text/babel" nonce="${nonceAttribute}">globalThis ?? window</script></head>`,
{ runScripts: "dangerously" },
);
return new Promise((resolve, reject) => {
dom.window.addEventListener("DOMContentLoaded", () => {
try {
const transformedScriptElement =
dom.window.document.head.children.item(2);
expect(transformedScriptElement.nonce).toBe(nonceAttribute);
resolve();
} catch (err) {
reject(err);
}
});
});
});
});
},
);
});
1 change: 0 additions & 1 deletion yarn.lock
Expand Up @@ -3915,7 +3915,6 @@ __metadata:
"@babel/preset-typescript": "workspace:^"
acorn: ^8.7.0
jsdom: ^22.1.0
semver: ^6.3.0
languageName: unknown
linkType: soft

Expand Down

0 comments on commit 2dc6f8d

Please sign in to comment.