Apply suggestions from code review

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
babel · Jan 19, 2024 · 210fc52 · 210fc52
1 parent c3ee8ac
commit 210fc52
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 10 deletions.
diff --git a/eslint/babel-eslint-parser/src/convert/convertAST.cts b/eslint/babel-eslint-parser/src/convert/convertAST.cts
@@ -2,7 +2,7 @@ import type * as t from "@babel/types";
 import ESLINT_VERSION = require("../utils/eslint-version.cts");
 import type { ParseResult } from "../types.d.cts";
 
-function* it(children: any) {
+function* it<T>(children: T | T[]): Generator<T> {
   if (Array.isArray(children)) yield* children;
   else yield children;
 }

diff --git a/eslint/babel-eslint-parser/src/convert/convertComments.cts b/eslint/babel-eslint-parser/src/convert/convertComments.cts
@@ -9,9 +9,6 @@ export = function convertComments(comments: Comment[]) {
     // even with options.ranges === true
 
     // @ts-expect-error eslint
-    if (!comment.range) {
-      // @ts-expect-error eslint
-      comment.range = [comment.start, comment.end];
-    }
+    comment.range ||= [comment.start, comment.end];
   }
 };
diff --git a/eslint/babel-eslint-parser/src/convert/convertTokens.cts b/eslint/babel-eslint-parser/src/convert/convertTokens.cts
@@ -101,11 +101,8 @@ function convertToken(
       pattern: string;
       flags: string;
     };
-  } = {
-    ...token,
-    type: "",
-    range: [token.start, token.end],
-  };
+  } = token as any;
+  newToken.range = [token.start, token.end];
 
   if (label === tl.name) {
     if (token.value === "static") {