- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename all enum cases to PascalCase instead of SHOUT_CASE #450
Conversation
Pull Request Test Coverage Report for Build 8416591862Details
💛 - Coveralls |
cbe1356
to
dd2ee94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's gonna be a bit of an annoying BC break for downstream usage though.
Just got to ask : Is it actually worth it? :)
I'm yes, it is worth it, for consistency sake. I do not assume that BC breaks are going to be a huge problem downstream, and its a major release, so BC breaks are expected. |
Signed-off-by: azjezz <azjezz@protonmail.com>
dd2ee94
to
4e5222f
Compare
Is there no way to leave an alias in place with the old name? This change make it incredibly tedious for libraries to support. Ideally, libraries that depend on this library could advertise |
quity tricky, and i don't want to include hacks in Psl for compatibilty. I don't recommand doing |
maybe create a rector rule for upgrading SHOUT_CASE to PascalCase? |
That is indeed a good idea 👍 I'm working on many things related to 3.x right now, and we might want to create rules for rector to upgrade. personally i don't think i have the time to do that, but if someone is willing to create the rules, we can have them in the github.com/php-standard-library org. |
closes #448
List of renamed cases