Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(locale): add Locale::default() function to retrieve default locale #447

Merged
merged 1 commit into from
Mar 24, 2024
Merged

chore(locale): add Locale::default() function to retrieve default locale #447

merged 1 commit into from
Mar 24, 2024
+165 −1

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Mar 23, 2024

No description provided.

@azjezz azjezz added Priority: Medium This issue may be useful, and needs some attention. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Status: Review Needed The issue has a PR attached to it which needs to be reviewed. Type: Enhancement Most issues will probably ask for additions or changes. labels Mar 23, 2024
@azjezz azjezz requested a review from veewee March 23, 2024 09:00
@azjezz azjezz self-assigned this Mar 23, 2024
@coveralls
Copy link

coveralls commented Mar 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8412216949

Details

  • 11 of 12 (91.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 98.995%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Psl/Locale/Locale.php 11 12 91.67%
Totals Coverage Status
Change from base Build 8338783735: -0.02%
Covered Lines: 4235
Relevant Lines: 4278
💛 - Coveralls

@azjezz azjezz force-pushed the chore/locale-default branch 2 times, most recently from 3668ea3 to 99fb164 Compare March 23, 2024 09:15
azjezz
azjezz commented Mar 23, 2024
View reviewed changes
@azjezz
feat(locale): add Locale::default() function to retrieve default lo…
Loading
Loading status checks…
25a47a7 
…cale

Signed-off-by: azjezz <azjezz@protonmail.com>
@azjezz azjezz force-pushed the chore/locale-default branch from 99fb164 to 25a47a7 Compare March 24, 2024 21:22
@azjezz azjezz merged commit 69728d2 into next Mar 24, 2024
28 checks passed
@azjezz azjezz deleted the chore/locale-default branch March 24, 2024 21:26
@azjezz azjezz added this to the 3.0.0 milestone Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veewee veewee

Assignees

@azjezz azjezz

Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Status: Review Needed The issue has a PR attached to it which needs to be reviewed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@azjezz @coveralls @veewee