Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHPUnit config file using lando phpunit --migrate-configuration #2788

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

trackleft
Copy link
Member

@trackleft trackleft commented Oct 5, 2023

Saw this in the PHPUnit output

113 Runtime:       PHP 8.1.17
114 Configuration: /src/az-quickstart-scaffolding/web/profiles/custom/az_quickstart/phpunit.xml.dist
115 Warning:       Your XML configuration validates against a deprecated schema.
116 Suggestion:    Migrate your XML configuration using "--migrate-configuration"!
image

This removed the <filter> section, possibly because the explaination here: sebastianbergmann/phpunit#5405 (comment)

Related issues

How to test

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@trackleft trackleft marked this pull request as ready for review October 5, 2023 01:21
@trackleft trackleft requested a review from a team as a code owner October 5, 2023 01:21
@trackleft trackleft added the ci Continuous integration / automation label Oct 5, 2023
@joeparsons
Copy link
Member

This is the commit that made a similar change to Drupal core's phpunit.xml.dist file:
https://git.drupalcode.org/project/drupal/-/commit/8220c9159701c867873be081e0cee004b413e927

Copy link
Member

@joeparsons joeparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem fine to me.

@joeparsons joeparsons added the enhancement New feature or request label Oct 5, 2023
@joeparsons joeparsons merged commit c86fbdc into main Nov 29, 2023
14 checks passed
@joeparsons joeparsons deleted the update-phpunit-config-file branch November 29, 2023 20:45
@joeparsons joeparsons mentioned this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.9.x only ci Continuous integration / automation enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants