Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CVE 2023 45857 #6028

Merged
merged 4 commits into from Oct 26, 2023
+4 −4
Merged

CVE 2023 45857 #6028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
53817f8
fix(lib/adapters/xhr.js): CVE-2023-45857
valentin-panov Oct 15, 2023
677c015
fix(lib/adapters/xhr.js): regarding CVE-2023-45857 config.withCredent…
valentin-panov Oct 25, 2023
d1fc9b2
Merge branch 'v1.x' into CVE-2023-45857
valentin-panov Oct 25, 2023
46f6e79
chore(test): convert to negative testcase;
DigitalBrainJS Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/adapters/xhr.js
View file
Open in desktop
Expand Up @@ -188,8 +188,8 @@ export default isXHRAdapterSupported && function (config) {
// Specifically not if we're in a web worker, or react-native.
if (platform.isStandardBrowserEnv) {
// Add xsrf header
const xsrfValue = (config.withCredentials || isURLSameOrigin(fullPath))
&& config.xsrfCookieName && cookies.read(config.xsrfCookieName);
// regarding CVE-2023-45857 config.withCredentials condition was removed temporarily
const xsrfValue = isURLSameOrigin(fullPath) && config.xsrfCookieName && cookies.read(config.xsrfCookieName);

if (xsrfValue) {
requestHeaders.set(config.xsrfHeaderName, xsrfValue);
Expand Down
4 changes: 2 additions & 2 deletions test/specs/xsrf.spec.js
View file
Open in desktop
Expand Up @@ -67,15 +67,15 @@ describe('xsrf', function () {
});
});

it('should set xsrf header for cross origin when using withCredentials', function (done) {
it('should not set xsrf header for cross origin when using withCredentials', function (done) {
document.cookie = axios.defaults.xsrfCookieName + '=12345';

axios('http://example.com/', {
withCredentials: true
});

getAjaxRequest().then(function (request) {
expect(request.requestHeaders[axios.defaults.xsrfHeaderName]).toEqual('12345');
expect(request.requestHeaders[axios.defaults.xsrfHeaderName]).toEqual(undefined);
done();
});
});
Expand Down