Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Unknown Kubelet Ready condition into Repair Policies #7514

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Dec 11, 2024

Fixes #7479

Description

  • Add Unknown status for the Kubelet Ready condition as a state to repair nodes.

How was this change tested?

  • /karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sorry, something went wrong.

@engedaam engedaam requested a review from a team as a code owner December 11, 2024 00:16
Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 0515aa8
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67593f15ef1de60008ebe733
😎 Deploy Preview https://deploy-preview-7514--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Dec 11, 2024

Pull Request Test Coverage Report for Build 12271642486

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 64.99%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloudprovider/cloudprovider.go 0 5 0.0%
Totals Coverage Status
Change from base Build 12265951884: -0.04%
Covered Lines: 5738
Relevant Lines: 8829

💛 - Coveralls

Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-1f01c4c0e3f664da50ad45b6c88558637a6b2de2.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-1f01c4c0e3f664da50ad45b6c88558637a6b2de2" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@engedaam engedaam force-pushed the add-unknown-ready-condition branch from 1a198ed to 0515aa8 Compare December 11, 2024 07:28
Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-0515aa884baabc8a5323076f0cac7aed8ad38c65.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-0515aa884baabc8a5323076f0cac7aed8ad38c65" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit fe32aae into aws:main Dec 11, 2024
33 of 35 checks passed
@engedaam engedaam deleted the add-unknown-ready-condition branch December 11, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node Repair: Expand to Handle "Unknown" Node Status
4 participants