Skip to content

test(client-s3): skip putObject blob body in browser #6801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 15, 2025

Issue

Internal JS-5678

Description

Temporarily skips blob body test for client-s3 in browser

Testing

Before

$ client-s3> yarn test:browser
...
 FAIL  test/e2e/S3.browser.e2e.spec.ts > @aws-sdk/client-s3 > PutObject > should succeed with blob body
TypeError: readableStream.on is not a function
 ❯ getAwsChunkedEncodingStream ../../node_modules/@smithy/util-stream/dist-cjs/getAwsChunkedEncodingStream.js:13:20
 ❯ test/browser-build/browser-s3-bundle.js:5802:21
    5800|     if (isStreaming(requestBody)) {
    5801|       const { getAwsChunkedEncodingStream: getAwsChunkedEncodingStream2, bodyLengthChecker } = config;
    5802|       updatedBody = getAwsChunkedEncodingStream2(requestBody, {
...
 Test Files  1 failed | 2 passed (3)
      Tests  1 failed | 25 passed | 1 skipped (27)

After

$ lib-storage> yarn test:browser
...
 Test Files  3 passed (3)
      Tests  25 passed | 2 skipped (27)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner January 15, 2025 04:28
@trivikr trivikr force-pushed the test-client-s3-browser branch from 3c6f024 to b599c2a Compare January 15, 2025 04:29
@trivikr trivikr merged commit e1dff72 into aws:main Jan 15, 2025
3 of 4 checks passed
@trivikr trivikr deleted the test-client-s3-browser branch January 15, 2025 04:41
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants