Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(lib-dynamodb): enhance type safety #6074

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

siddsriv
Copy link
Contributor

@siddsriv siddsriv commented May 8, 2024

Issue

Internal JS-5189

Description

  1. Defines NestedList and NestedMap types to describe structure of nested arrays and objects within test data, addressing TS2322 errors.
  2. Adds an index signature to the DataType interface for addressing TS7053 errors that occurred when attempting to index objects without explicit index signatures.
  3. Explicitly types the passError parameter as any, for TS7006 errors.

Testing

 PASS  src/test/lib-dynamodb.e2e.spec.ts (31.098 s)
  DynamoDBDocument
    ✓ initializes using the static constructor
    ✓ is using a random TableName=js-sdk-dynamodb-test-1715128811-le0x (1 ms)
    ✓ describes the test table
    ✓ creates the test table if it does not exist
    .
    .
    .
    ✓ can serialize class instances as maps (1 ms)
    updateTransformFunction
      ✓ modifies all fields of an object (3 ms)

Test Suites: 1 passed, 1 total
Tests:       85 passed, 85 total
Snapshots:   0 total
Time:        31.186 s
Ran all test suites.
Done in 32.00s.

Checklist

  • If you wrote E2E tests, are they resilient to concurrent I/O?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sorry, something went wrong.

@siddsriv siddsriv requested a review from a team as a code owner May 8, 2024 00:41
@trivikr trivikr merged commit 74e4c14 into aws:main May 8, 2024
5 checks passed
@siddsriv siddsriv deleted the lib-dyn-e2e-fix branch May 8, 2024 13:24
siddsriv added a commit to siddsriv/aws-sdk-js-v3 that referenced this pull request May 8, 2024
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants