Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scripts): use caret when updating aws-sdk peerDependencies #6031

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Apr 26, 2024

Issue

Noticed in #6027

Description

Use caret when updating aws-sdk peerDependencies

Testing

Ran the scripts to ensure peerDependencies are updated correctly

$ yarn update:versions:current

$ git diff lib/lib-dynamodb/package.json
diff --git a/lib/lib-dynamodb/package.json b/lib/lib-dynamodb/package.json
index f3219749ada..c9744a1f1f0 100644
--- a/lib/lib-dynamodb/package.json
+++ b/lib/lib-dynamodb/package.json
@@ -26,16 +26,16 @@
   },
   "license": "Apache-2.0",
   "dependencies": {
-    "@aws-sdk/util-dynamodb": "*",
+    "@aws-sdk/util-dynamodb": "3.564.0",
     "@smithy/smithy-client": "^2.5.1",
     "@smithy/types": "^2.12.0",
     "tslib": "^2.6.2"
   },
   "peerDependencies": {
-    "@aws-sdk/client-dynamodb": "*"
+    "@aws-sdk/client-dynamodb": "^3.564.0"
   },
   "devDependencies": {
-    "@aws-sdk/client-dynamodb": "*",
+    "@aws-sdk/client-dynamodb": "3.564.0",
     "@tsconfig/recommended": "1.0.1",
     "@types/node": "^14.14.31",

$ yarn update:versions:default

$ git status
On branch update-peer-dependencies
Your branch is up to date with 'origin/update-peer-dependencies'.

nothing to commit, working tree clean

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review April 26, 2024 20:26
@trivikr trivikr requested a review from a team as a code owner April 26, 2024 20:26
@trivikr trivikr merged commit 0d54a05 into aws:main Apr 26, 2024
3 of 5 checks passed
@trivikr trivikr deleted the update-peer-dependencies branch April 26, 2024 20:27
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants