Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix inline script variable name collision #5789

Merged
merged 1 commit into from Feb 13, 2024
Merged

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Feb 13, 2024

fix a build step that renamed variables in a way that collided

pre-transform:

var import_core = require("@smithy/core");
var import_core2 = require("@aws-sdk/core");

import_core.prop;
import_core2.prop;
var import_core3 = require("@smithy/core");
import_core3.prop;
var import_core4 = require("@aws-sdk/core");
import_core4.prop;

broken:

var import_core = require("@smithy/core");
var import_core = require("@aws-sdk/core");

import_core.prop;
import_core.prop;
import_core.prop;
import_core.prop;

fix:

var import_core = require("@smithy/core");
var import_core2 = require("@aws-sdk/core");

import_core.prop;
import_core2.prop;
import_core.prop;
import_core2.prop;

@kuhe kuhe requested a review from a team as a code owner February 13, 2024 17:17
@kuhe kuhe merged commit f0ac43a into aws:main Feb 13, 2024
2 of 3 checks passed
@kuhe kuhe deleted the fix/build branch February 13, 2024 17:30
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants