Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing documentation for error handling #5466

Closed
wants to merge 1 commit into from
Closed

Conversation

Chengxuan
Copy link

Issue

Issue number, if available, prefixed with "#"

Description

What does this implement/fix? Explain your changes.

The error object looks like below:

{
  "name":"NoSuchBucket",
  "$fault":"client",
  "$metadata": {
    "httpStatusCode": 404,
    "requestId":"xxx",
    "extendedRequestId":"xxx=",
    "attempts":1,
    "totalRetryDelay":0
  },
  "Code":"NoSuchBucket",
  "BucketName":"xxx",
  "RequestId":"xxx",
  "HostId":"xxx=",
  "message":"The specified bucket does not exist"
}

So the example code snippet doesn't work as it had an extra $.

Testing

How was this change tested?

Against an AWS S3 service

Additional context

Add any other context about the PR here.

Checklist

  • If you wrote E2E tests, are they resilient to concurrent I/O?
  • If adding new public functions, did you add the @public tag and enable doc generation on the package?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Chengxuan Chengxuan requested a review from a team as a code owner November 8, 2023 14:16
@Chengxuan Chengxuan changed the title Update README.md Fixing documentation for error handling Nov 8, 2023
@kuhe
Copy link
Contributor

kuhe commented Nov 10, 2023

this requires a code generation fix, so it will be done in #5476

@kuhe kuhe closed this Nov 10, 2023
@Chengxuan Chengxuan deleted the patch-1 branch November 10, 2023 18:00
@Chengxuan Chengxuan restored the patch-1 branch November 10, 2023 18:00
@Chengxuan Chengxuan deleted the patch-1 branch November 10, 2023 18:00
@Chengxuan
Copy link
Author

thanks @kuhe

@Chengxuan Chengxuan restored the patch-1 branch November 10, 2023 18:05
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants