Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(middleware-host-header): add test for :authority header in integ test #5374

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

siddsriv
Copy link
Contributor

Issue

Internal JS-4777

Description

Adds a test case in integration test to check that the :authority pseudo-header is set when using HTTP/2.0

Testing

Integration tests pass.

 PASS  src/middleware-host-header.integ.spec.ts
  middleware-host-header
    SageMaker
      ✓ should set the host header (51 ms)
      ✓ should set the authority header when using http2 (3 ms)

Test Suites: 1 passed, 1 total
Tests:       2 passed, 2 total
Snapshots:   0 total
Time:        4.891 s, estimated 6 s
Ran all test suites.
Done in 5.57s.

Additional context

PR that adds the authority section of target URI to the :authority pseudo-header: #5369


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@siddsriv siddsriv requested a review from a team as a code owner October 17, 2023 16:22
@siddsriv siddsriv force-pushed the authorityheader--integ-test branch from 2305f88 to 8a59c25 Compare October 17, 2023 16:50
@siddsriv siddsriv merged commit 3f121a1 into aws:main Oct 17, 2023
@siddsriv siddsriv deleted the authorityheader--integ-test branch October 17, 2023 19:49
Copy link

github-actions bot commented Nov 1, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants