feat(experimentalIdentityAndAuth): release phase for services with signing customizations #5286
Conversation
syall
force-pushed
the
experimentalIdentityAndAuth-phase-4
branch
from
817d829 to
7c69bad
Compare
syall
changed the title
syall
force-pushed
the
experimentalIdentityAndAuth-phase-4
branch
from
7c69bad to
50b2bbb
Compare
| new DefaultIdentityProviderConfig({ | ||
| "aws.auth#sigv4": config.credentials, | ||
| }); | ||
| } |
There was a problem hiding this comment.
private methods should be at the bottom of a class
There was a problem hiding this comment.
Got it. I think this will require intercepting a different code section in smithy-typescript.
Currently it intercepts ClientPropertiesCodeSection, but I'm thinking for the private methods, it should intercept ClientBodyExtraCodeSection: https://github.com/smithy-lang/smithy-typescript/blob/9972041f7d31886e035ec68bffc5f0af12512dd3/smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/ServiceBareBonesClientGenerator.java#L335C34-L335C60
There was a problem hiding this comment.
| { | ||
| schemeId: "aws.auth#sigv4", | ||
| identityProvider: (ipc: IdentityProviderConfig) => ipc.getIdentityProvider("aws.auth#sigv4"), | ||
| signer: new AWSSDKSigV4Signer(), |
There was a problem hiding this comment.
a bit late to address this, but this class should be called AwsSdkSigV4Signer. We don't capitalize other abbreviations like in HttpHandler
There was a problem hiding this comment.
/**
* @deprecated renamed.
*/
export const AWSSDKSigV4Signer = AwsSdkSigV4Signer;
…gning customizations Services: - RDS - EC2 - Polly
syall
force-pushed
the
experimentalIdentityAndAuth-phase-4
branch
from
559882b to
27821e7
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
Issue number, if available, prefixed with "#"
N/A.
Description
What does this implement/fix? Explain your changes.
Release
experimentalIdentityAndAuthsupport for services with signing customizations inaws-sdk-js-v3.Services:
TODO:
Testing
How was this change tested?
CI passes.
Additional context
Add any other context about the PR here.
Revert release PR: #5287
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.