feat(experimentalIdentityAndAuth): codegen @endpointRuleSet HttpAuthSchemeProviders
#5231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syall
changed the title
@endpointRuleSet HttpAuthSchemProviders@endpointRuleSet HttpAuthSchemeProviders
syall
force-pushed
the
add-endpointRuleSet-httpAuthSchemeProvider
branch
9 times, most recently
from
11c7b0a
to
1a93d42
Compare
syall
commented
Sep 21, 2023
...escript/codegen/auth/http/integration/AwsCustomizeEndpointRuleSetHttpAuthSchemeProvider.java
Outdated
Show resolved
Hide resolved
…eric client test
…thSchemeProvider`s For S3 and EventBridge, use `HttpAuthSchemeProvider`s based on `@smithy.rules#endpointRuleSet`, and also add in a partial `@aws.auth#sigv4a` `HttpAuthScheme` registration.
syall
force-pushed
the
add-endpointRuleSet-httpAuthSchemeProvider
branch
from
1a93d42
to
129fa2e
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Issue number, if available, prefixed with "#"
N/A.
Description
What does this implement/fix? Explain your changes.
Dependent on: smithy-lang/smithy-typescript#956, smithy-lang/smithy-typescript#957
Note: everything is gated by the
experimentalIdentityAndAuthflag, and will not actually be released until manually enabledThis PR introduces codegen for
@endpointRuleSetHttpAuthSchemeProviders for S3 and EventBridge only.This PR also introduces adding the
@endpointRuleSettrait to the generic client test.Testing
How was this change tested?
Note: everything is gated by the
experimentalIdentityAndAuthflagS3
Branch for testing: https://github.com/syall/aws-sdk-js-v3/commits/s3-testing
experimentalIdentityAndAuth(no@endpointRuleSetHttpAuthSchemeProvider): syall@7c9f189experimentalIdentityAndAuthand@endpointRuleSetHttpAuthSchemeProviderchanges: syall@5cffb01EventBridge
Branch for testing: https://github.com/syall/aws-sdk-js-v3/commits/eventBridge-testing
experimentalIdentityAndAuth(no@endpointRuleSetHttpAuthSchemeProvider): syall@69775feexperimentalIdentityAndAuthand@endpointRuleSetHttpAuthSchemeProviderchanges: syall@68066bdAdditional context
Add any other context about the PR here.
N/A.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.